From 33de6181367e209222d48088c37908d4847805e4 Mon Sep 17 00:00:00 2001 From: Paillat Date: Sat, 3 Aug 2024 17:14:42 +0200 Subject: [PATCH] :bug: Fix custom_id always required --- examples/color_select.py | 2 -- src/pycord_reactive_views/components.py | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/color_select.py b/examples/color_select.py index 585ea24..89c460c 100644 --- a/examples/color_select.py +++ b/examples/color_select.py @@ -43,10 +43,8 @@ class ColourSelector(ReactiveView): for colour in colors ], placeholder="Select a colour", - custom_id="colour_select", ) self.shade_select = ReactiveSelect( - custom_id="shade_select", placeholder="Select a shade", options=ReactiveValue( lambda: [ diff --git a/src/pycord_reactive_views/components.py b/src/pycord_reactive_views/components.py index 2a0200e..70f6324 100644 --- a/src/pycord_reactive_views/components.py +++ b/src/pycord_reactive_views/components.py @@ -51,7 +51,8 @@ class ReactiveButton(discord.ui.Button, Reactive): # pyright: ignore[reportUnsa self.add_reactive("url", url) self.add_reactive("emoji", emoji) self.add_reactive("row", row) - self.custom_id = custom_id + if custom_id: + self.custom_id = custom_id self.sku_id = sku_id